Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-2031 display error message when star search fails with prod filtering enabled #2005

Merged
merged 4 commits into from
Mar 11, 2021

Conversation

kvnwang
Copy link
Contributor

@kvnwang kvnwang commented Mar 2, 2021

What?

ES-2031 display error message when star search fails with prod filtering enabled

Screenshots (if appropriate)

Screen Shot 2021-03-02 at 2 50 05 PM

Screen Shot 2021-03-02 at 2 49 57 PM

Screen Shot 2021-03-02 at 2 49 52 PM

@bigbot
Copy link

bigbot commented Mar 2, 2021

Autotagging @bigcommerce/themes-team

@kvnwang kvnwang changed the title Es 2031 ES-2031 display error message when star search fails with prod filtering enabled Mar 2, 2021
@lord2800
Copy link
Contributor

lord2800 commented Mar 3, 2021

cc @bigcommerce/themes-team we're happy with these changes, as they mirror the changes we made for the search page.

lang/en.json Outdated Show resolved Hide resolved
lang/en.json Outdated Show resolved Hide resolved
templates/components/category/product-listing.html Outdated Show resolved Hide resolved
Copy link
Contributor

@BC-tymurbiedukhin BC-tymurbiedukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please a changelog item (see other PRs for refs)

@bc-dhuynh bc-dhuynh merged commit 5710ac6 into bigcommerce:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants