fix(search): ES-2138 fixed count showing issue for category facet #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/themes-team |
BC-tymurbiedukhin
requested review from
yurytut1993,
BC-tymurbiedukhin,
bc-alexsaiannyi and
bc-azvierieva
|
@bc-krishsenthilraj looks fine to me. Just add please a record to changelog. |
bc-dhuynh
approved these changes
Apr 9, 2021
bc-krishsenthilraj
force-pushed
the
ES-2138
branch
from
2b5f897
to
d434ca4
Compare
bc-krishsenthilraj
force-pushed
the
ES-2138
branch
from
d434ca4
to
9287f53
Compare
bc-dhuynh
approved these changes
Apr 9, 2021
lord2800
approved these changes
Apr 9, 2021
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Category facet does not show product count next to it when the count is
0.Why?
In theme file we have a check to show product count for
Categoryfacet only if it is greater than0. Since, for our use case the count is0, it's not shown. So, I have removed theifblock to show the count always. For all other facets we show the count always. Only forCategoryit is different. To keep consistency across all facets this fix is made.Tickets / Documentation
Screenshots (if appropriate)
Note: Please use the theme file (
Cornerstone-5.3.0_ES-2138_Fix.zip) uploaded to ES-2138.Steps:
Login to CP
Navigate to Storefront -> My Themes, upload the theme file & apply it
Follow the steps provided in the ticket
Observe that product count is shown next to
CategoryfacetAfter Fix:
Before Fix:
