fix(storefront): STRF-9126 Facebook social share returns an error for blog pages #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/themes-team |
junedkazi
approved these changes
Jun 10, 2021
BC-tymurbiedukhin
approved these changes
Jun 10, 2021
Changed the link |
Closed
|
@jairo-bc @BC-tymurbiedukhin @junedkazi @bookernath @bigcommerce/themes-team this PR breaks social sharing for product pages. i've opened issue #2081 for this |
rowleyaj
added a commit
to craftkitsnbits/cornerstone
that referenced
this pull request
Jun 19, 2021
this fixes product page social sharing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Facebook social share was returning an error for blog pages, because ?u=
undefined. getVar and assignVar works as expected, problem was in the url variable, that is undefined.Tickets / Documentation
Screenshots (if appropriate)