Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payment): PAYPAL-1654 add styling config for the PayPal Accelera… #2254

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

koa75
Copy link
Contributor

@koa75 koa75 commented Sep 5, 2022

…ted Checkout button

What?

Add the Accelerated checkout button style settings to the Page builder

The merchants want to be able to change the appearance of the PayPal Accelerated Checkout button so that they could match overall website design

Requirements

Related PR https://github.com/bigcommerce/bigcommerce/pull/48391

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Screenshots (if appropriate)

Screenshot 2022-09-05 at 20 05 47

@koa75 koa75 force-pushed the PAYPAL-1654 branch 3 times, most recently from 853ce7f to 92cfbfc Compare September 5, 2022 14:22
@koa75 koa75 marked this pull request as ready for review September 6, 2022 10:45
@koa75 koa75 marked this pull request as draft September 6, 2022 10:46
@koa75 koa75 marked this pull request as ready for review September 6, 2022 10:49
@bc-fetisov
Copy link
Contributor

According to attached screen, accelerated has been placed checkout on the top, but i think it should be at the bottom, follow after Checkout PayPal Button, from most frequently used to lower: Smart Paypal Button -> Checkout PayPal Button -> Accelerated Button

config.json Show resolved Hide resolved
@koa75
Copy link
Contributor Author

koa75 commented Sep 6, 2022

According to attached screen, accelerated has been placed checkout on the top, but i think it should be at the bottom, follow after Checkout PayPal Button, from most frequently used to lower: Smart Paypal Button -> Checkout PayPal Button -> Accelerated Button

see figma design https://www.figma.com/file/IdLt53nCXwNH0OJB7M0uq5/PPCP-Phase-1-%E2%86%92-3-%E2%80%94-Onboarding-flow-%2B-Checkout-options?node-id=4160%3A7317

@bc-fetisov
Copy link
Contributor

According to attached screen, accelerated has been placed checkout on the top, but i think it should be at the bottom, follow after Checkout PayPal Button, from most frequently used to lower: Smart Paypal Button -> Checkout PayPal Button -> Accelerated Button

see figma design https://www.figma.com/file/IdLt53nCXwNH0OJB7M0uq5/PPCP-Phase-1-%E2%86%92-3-%E2%80%94-Onboarding-flow-%2B-Checkout-options?node-id=4160%3A7317

@nkostohryz Should Accelerated Button block be placed over the other existing blocks?

@nkostohryz
Copy link

According to attached screen, accelerated has been placed checkout on the top, but i think it should be at the bottom, follow after Checkout PayPal Button, from most frequently used to lower: Smart Paypal Button -> Checkout PayPal Button -> Accelerated Button

Thanks for your input @bc-fetisov !

from most frequently used to lower

AC is always located at the top of the page on storefront (cart page), therefore it makes sense to keep it consistent and keep at the top within theme settings as well.

1 similar comment
@nkostohryz
Copy link

According to attached screen, accelerated has been placed checkout on the top, but i think it should be at the bottom, follow after Checkout PayPal Button, from most frequently used to lower: Smart Paypal Button -> Checkout PayPal Button -> Accelerated Button

Thanks for your input @bc-fetisov !

from most frequently used to lower

AC is always located at the top of the page on storefront (cart page), therefore it makes sense to keep it consistent and keep at the top within theme settings as well.

@BC-krasnoshapka BC-krasnoshapka merged commit b634d5a into bigcommerce:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants