Allow quantity of "0" in cart to remove item #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BC-krasnoshapka
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Code looks good. @bc-as what do you think about this feature?
|
This looks great, @sacr3dc0w! I'm on board to get this merged - @BC-krasnoshapka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently, when you type in a quantity 0, you receive an error alert letting you know that's not an accepted value. This PR allows 0 so the customer can remove the line item from the cart without taking a separate action like clicking the minus button or the delete link.
Screenshots
BEFORE
01.before.mov
AFTER
02.after.mov