Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payment): PAYPAL-1783 fix styles for wallet buttons #2285

Merged
merged 3 commits into from Dec 15, 2022

Conversation

bc-nick
Copy link
Contributor

@bc-nick bc-nick commented Nov 18, 2022

What?

Fixed styles for wallet buttons on the Product Detail Page

Tickets / Documentation

Depends on

https://github.com/bigcommerce/smart-payment-buttons/pull/13

Screenshots (if appropriate)

Braintree

braintree-bnts-1

braintree-bnts-2

braintree-applepay

PaypalCommerce

paypalcommerce-btns-2

paypalcommerce-btns-1

@bc-nick bc-nick marked this pull request as ready for review November 18, 2022 14:51
@BC-krasnoshapka
Copy link
Contributor

hi @bc-nick , it would be nice to drop a line in CHANGELOG, thanks

@bc-nick bc-nick changed the title feat(payment): PAYPAL-1783 fix styles for wallet buttons feat(payment): PAYPAL-1783 fix styles for wallet buttons Nov 21, 2022
@bc-nick bc-nick changed the title feat(payment): PAYPAL-1783 fix styles for wallet buttons feat(payment): PAYPAL-1783 fix styles for wallet buttons | DO NOT MERGE Nov 21, 2022
@bc-nick bc-nick closed this Nov 21, 2022
@bc-nick bc-nick reopened this Nov 21, 2022
@BC-krasnoshapka
Copy link
Contributor

@bc-nick is this ready to merge? Can you resolve conflicts please?

@bc-nick bc-nick changed the title feat(payment): PAYPAL-1783 fix styles for wallet buttons | DO NOT MERGE feat(payment): PAYPAL-1783 fix styles for wallet buttons Dec 13, 2022
@bc-nick
Copy link
Contributor Author

bc-nick commented Dec 13, 2022

@BC-krasnoshapka conflicts have been resolved. ready to merge

@BC-krasnoshapka BC-krasnoshapka merged commit 7187ed4 into bigcommerce:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants