Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payment): PAYPAL-2495 added ACH payment method section to My Account -> Payment Methods page #2362

Merged
merged 2 commits into from
Jun 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- (sanitize product.description) in the theme results to ‘error length of description’ from Google indexing for lengthy product description [#2363](https://github.com/bigcommerce/cornerstone/pull/2363)
- Added style configs to payment buttons [#2361](https://github.com/bigcommerce/cornerstone/pull/2361)
- Bump Stencil utils to 6.15.1 [#2365][https://github.com/bigcommerce/cornerstone/pull/2365]
- Added ACH payment method section to My Account -> Payment Methods page [#2362](https://github.com/bigcommerce/cornerstone/pull/2362)

## 6.11.0 (05-24-2023)
- Reverted fix for sold-out badge appearance [#2354](https://github.com/bigcommerce/cornerstone/pull/2354)
Expand Down
4 changes: 4 additions & 0 deletions assets/img/payment-methods/ach.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@
"payment_methods": {
"heading": "Payment Methods",
"payment_method": "Payment method",
"bank_account": "Bank account",
"billing_address": "Billing address",
"card_ending_in": "ending in {last_four}",
"card_expiry": "{month}/{year}",
Expand All @@ -409,6 +410,7 @@
"unionpay": "Union Pay",
"visa": "Visa"
},
"ach": "ACH",
"paypal": "PayPal",
"billing_address_labels": {
"address_line_1": "Address Line 1",
Expand Down
11 changes: 7 additions & 4 deletions templates/components/account/payment-methods-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,13 @@ <h4 class="paymentMethodsTitle">

{{#if type '===' 'stored_bank_account'}}
{{!-- If bank_account STARTS --}}
<img class="methodHeader-icon" src="{{cdn 'img/payment-methods/card.svg'}}"
alt="{{lang 'account.payment_methods.card_types.credit_card'}}"
title="{{lang 'account.payment_methods.card_types.credit_card'}}">
<span class="methodHeader-brand">{{ lang 'account.payment_methods.payment_method'}}</span>
{{#if ../methodId '===' 'ach'}}
<img class="methodHeader-icon" src="{{cdn 'img/payment-methods/ach.svg'}}" alt="{{lang 'account.payment_methods.ach'}}" title="{{lang 'account.payment_methods.ach'}}">
<span class="methodHeader-brand">{{lang 'account.payment_methods.bank_account'}} {{lang 'account.payment_methods.card_ending_in' last_four=masked_account_number}}</span>
{{else}}
<img class="methodHeader-icon" src="{{cdn 'img/payment-methods/card.svg'}}" alt="{{lang 'account.payment_methods.card_types.credit_card'}}" title="{{lang 'account.payment_methods.card_types.credit_card'}}">
<span class="methodHeader-brand">{{lang 'account.payment_methods.payment_method'}}</span>
{{/if}}
{{!-- If bank_account ENDS --}}
{{/if}}

Expand Down
Loading