chore: DATA-11172 Populate data tags despite of data_tag_enabled setting #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the nick of time. Thanks 🥳 |
BC-krasnoshapka
approved these changes
Jun 27, 2023
bc-vlad-dlogush
approved these changes
Jun 30, 2023
|
It would also help if data_tag_enabled was not dependent on Universal being enabled. That way older themes will continue to include the data attributes without Universal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? DATA-11172
Previously we populated data tags only when Universal Google Analytics was enabled. Since it's now going away there will be no way for merchants to enable these data tags on their stores. As some merchants were using them to build their custom analytics integrations, it has been decided to populate data tags for all merchants despite of
data-tag_enablesetting, so that they can proceed using it even when Universal Google Analytics is gone.Requirements
Tickets / Documentation
Add links to any relevant tickets and documentation.