Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct typo in default it appears deafault #2410

Merged

Conversation

danielphilipjohnson
Copy link
Contributor

What?

This PR addresses a small typo found in the naming of the default banner background color class. The typo could potentially lead to styling issues or confusion among developers.

Changes

  • Corrected the class name from banner--deafault-backgroundColor to banner--default-backgroundColor.
  • Updated all occurrences of this typo in both the configuration file and alert.scss to ensure consistency and correct functionality.

Impact

  • The correction of this typo will ensure that the default banner background color is applied as intended across the application.
  • Developers will now find the correctly named class, aligning with standard naming conventions, thus improving code readability and maintainability.

Additional Notes

  • No changes were made to the functionality or visual aspects of the banner; this PR strictly corrects the class name typo.
  • I have verified that this change does not affect any other components or styles.

Thank you for considering this PR. I'm open to any feedback or additional changes that might be necessary!

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Change banner--deafault-backgroundColor to banner--default-backgroundColor

Changed inside config and alert.scss where it is being used
@danielphilipjohnson danielphilipjohnson marked this pull request as ready for review December 15, 2023 14:34
Copy link
Contributor

@BC-krasnoshapka BC-krasnoshapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@BC-krasnoshapka BC-krasnoshapka merged commit 88d37a9 into bigcommerce:master Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants