STENCIL-2598 - Add GeoTrust SSL Seal Toggle #903

mjschock · 2017-01-11T19:28:24Z

what (STENCIL-2598, formerly MERC-1160)

adds a toggle for the GeoTrust SSL Seal
implements the the instructions here
the domain and size can be set

@bigcommerce/stencil-team

bigbot · 2017-01-11T19:28:25Z

Autotagging @mcampa @bc-miko-ademagic @davidchin

stencil-bot · 2017-01-11T19:28:26Z

Generating bundle for commit dc07693

stencil-bot · 2017-01-11T19:55:10Z

Generating bundle for commit ac717b0

stencil-bot · 2017-01-11T20:08:02Z

Generating bundle for commit 8d99a41

mcampa

👍

willfaught · 2017-01-25T01:47:10Z

templates/components/common/ssl-seal.html

+            <a href="http://www.geotrust.com/ssl/" target="_blank"  style="color:#000000; text-decoration:none; font:bold 7px verdana,sans-serif; letter-spacing:.5px; text-align:center; margin:0px; padding:0px;"></a>
+        </td>
+    </tr>
+</table>


hmmm... yes, i see. the linter doesn't look at html or json. wondering if we should add something to do the check.

i've added a new line at the end but it doesn't seem to show up here, although you can see that there are now 9 lines: https://github.com/mjschock/stencil/blob/f80cdfc06862a9668db449697261c8d9a07eb4a2/templates/components/common/ssl-seal.html

willfaught · 2017-01-25T01:47:23Z

config.json

@@ -590,4 +593,4 @@
      }
    }
  ]
-}
+}


it's been added. see https://github.com/mjschock/stencil/blob/f80cdfc06862a9668db449697261c8d9a07eb4a2/config.json.

willfaught · 2017-01-25T01:53:09Z

🍹 Keep in mind https://github.com/bigcommerce/standards/blob/master/docs/Git.md. Can we add the ticket (MERC-1160?) to the summary and use a verb (add?) and sentence case (Add GeoTrust SSL to do...)?

mcampa · 2017-01-25T18:25:57Z

.eslintrc

@@ -7,7 +7,7 @@
        "complexity": 1,
        "no-alert": 0,
        "consistent-return": 0,
-        "max-len": 0,
+        "max-len": 0


Unnecessary change. .eslintrc is not "real" json format 🍹 .
You can have trailing commas and add comments in this file

yeah, just removed it because vscode doesn't like it. it's been added back :)

junedkazi · 2017-01-31T21:56:46Z

config.json

-    "social_icon_placement_bottom": "bottom_none"
+    "social_icon_placement_bottom": "bottom_none",
+    "show_geotrust_ssl_seal": false,
+    "geotrust_ssl_seal_hostname": "",


why not use shopPath instead ? Is there a reason for not using the store domain instead of offering a separate field ?

Good question, however shopPath or ShopPathSSL return a url http://... not the hostname. But we could return the hostname in the Setting resource and use that

We do have base_url & secure_base_url for both http & https links. We also have the home in the urls section of the context. All the urls are with http{s}:// so we will need to strip them out. The question is should we pass it as resource on the bcapp side or just add a helper in pencil to strip http{s}://.

+1 It would be useful to have helper for that. Like getHostname

But the question is if merchants really need to enter their own domain

Since the trust ssl seal is for the store domain name. I don't see a reason why we should expose a field for the user to enter it unless there is some historic reason which I am not aware of.

mcampa · 2017-02-07T21:02:16Z

We are now using CHANGELOG.md. Please add an entry with your change under draft before merging

## Draft
- <here>

## 1.5.1 (2017-02-07)
- ...

junedkazi

Changelog is missing for this PR

mjschock · 2017-02-10T18:22:36Z

CHANGELOG.md

@@ -5,6 +5,7 @@
 - Prevent carousel images from being cut off on large screens by adding a new setting to theme editor schema [#909](https://github.com/bigcommerce/stencil/pull/909)
 - Add schema description specifying that social media icons must be set up to see them [#920](https://github.com/bigcommerce/stencil/pull/920)
 - Show account creation links only if it is enabled in store settings [#917] (https://github.com/bigcommerce/stencil/pull/917)
+- Add GeoTrust SSL Seal Toggle [#903] (https://github.com/bigcommerce/stencil/pull/903)


@junedkazi - updated

junedkazi · 2017-02-10T18:24:31Z

@nickdengler can we test this one before we merge it.

nickdengler · 2017-02-14T19:35:44Z

LGTM 💚

mjschock force-pushed the spraypaint branch from cd59fc1 to cef32b0 Compare January 11, 2017 20:01

mcampa approved these changes Jan 11, 2017

View reviewed changes

mjschock force-pushed the spraypaint branch from cef32b0 to e9f4208 Compare January 11, 2017 21:07

mjschock changed the base branch from spraypaint to master January 12, 2017 21:53

mjschock assigned nickdengler Jan 25, 2017

willfaught reviewed Jan 25, 2017

View reviewed changes

mjschock changed the title ~~geotrust ssl seal~~ Add GeoTrust SSL Jan 25, 2017

mjschock changed the title ~~Add GeoTrust SSL~~ STENCIL-2598 - Add GeoTrust SSL Seal Toggle Jan 25, 2017

mcampa reviewed Jan 25, 2017

View reviewed changes

junedkazi reviewed Jan 31, 2017

View reviewed changes

Michael Schock and others added 2 commits February 9, 2017 17:47

STENCIL-2598 - Add GeoTrust SSL Seal Toggle

ad9a810

STENCIL-2598 using secure_host from the store settings

e165ada

junedkazi approved these changes Feb 10, 2017

View reviewed changes

junedkazi suggested changes Feb 10, 2017

View reviewed changes

update changelog

da4f570

mjschock commented Feb 10, 2017

View reviewed changes

junedkazi approved these changes Feb 10, 2017

View reviewed changes

mjschock merged commit 8113b67 into bigcommerce:master Feb 14, 2017

mjschock deleted the MERC-1160 branch February 14, 2017 19:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STENCIL-2598 - Add GeoTrust SSL Seal Toggle #903

STENCIL-2598 - Add GeoTrust SSL Seal Toggle #903

mjschock commented Jan 11, 2017 •

edited

bigbot commented Jan 11, 2017

stencil-bot commented Jan 11, 2017

stencil-bot commented Jan 11, 2017

stencil-bot commented Jan 11, 2017

mcampa left a comment

willfaught Jan 25, 2017

mjschock Jan 25, 2017

mjschock Jan 25, 2017

willfaught Jan 25, 2017

mjschock Jan 25, 2017

willfaught commented Jan 25, 2017 •

edited

mcampa Jan 25, 2017 •

edited

mjschock Jan 25, 2017

junedkazi Jan 31, 2017

mcampa Jan 31, 2017

junedkazi Jan 31, 2017

mcampa Jan 31, 2017

junedkazi Jan 31, 2017

mcampa commented Feb 7, 2017

junedkazi left a comment

mjschock Feb 10, 2017

junedkazi commented Feb 10, 2017 •

edited

nickdengler commented Feb 14, 2017

@@ @@ -590,4 +593,4 @@ @@
                     }
                   }
                 ]
-              }
+              }

STENCIL-2598 - Add GeoTrust SSL Seal Toggle #903

STENCIL-2598 - Add GeoTrust SSL Seal Toggle #903

Conversation

mjschock commented Jan 11, 2017 • edited

what (STENCIL-2598, formerly MERC-1160)

bigbot commented Jan 11, 2017

stencil-bot commented Jan 11, 2017

stencil-bot commented Jan 11, 2017

stencil-bot commented Jan 11, 2017

mcampa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

willfaught commented Jan 25, 2017 • edited

mcampa Jan 25, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcampa commented Feb 7, 2017

junedkazi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junedkazi commented Feb 10, 2017 • edited

nickdengler commented Feb 14, 2017

mjschock commented Jan 11, 2017 •

edited

willfaught commented Jan 25, 2017 •

edited

mcampa Jan 25, 2017 •

edited

junedkazi commented Feb 10, 2017 •

edited