STENCIL-2448: Add expanded view of swatch on hover #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @mcampa @bc-miko-ademagic @davidchin |
bc-ong
force-pushed
the
STENCIL-2448
branch
2 times, most recently
from
3ce0a98
to
aeb69c4
Compare
|
Can you please add an entry to the |
|
Also, can you post a screenshot on how this looks? :) |
mjschock
reviewed
Feb 15, 2017
| @@ -12,8 +12,44 @@ $position_of_x : str-index($value_of_swatch_size, "x"); | |||
| $first_value : str-slice($value_of_swatch_size, 0, $position_of_x - 1); | |||
| $second_value : str-slice($value_of_swatch_size, $position_of_x + 1); | |||
|
|
|||
| [data-product-attribute] .form-option.form-option-swatch { | |||
There was a problem hiding this comment.
should this be [data-product-attribute-value] instead?
There was a problem hiding this comment.
This selector is overriding the following selector: [data-product-attribute] .form-option
mcampa
approved these changes
Feb 15, 2017
STENCIL-2448: update changelog
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a larger view of a swatch image when option is hovered over.
@mjschock @mcampa