STENCIL-3194: Adds theme editor setting for product display mode (grid vs list). #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix the newline and this looks good to me. |
junedkazi
suggested changes
Feb 23, 2017
schema.json
Outdated
| @@ -2105,4 +2124,4 @@ | |||
| } | |||
| ] | |||
| } | |||
| ] | |||
| ] | |||
There was a problem hiding this comment.
Need an extra line I guess.
….Mass comm has been sent. Closing case.Merge branch 'master' of https://github.com/bigcommerce/stencil into STENCIL-3194
junedkazi
suggested changes
Feb 24, 2017
schema.json
Outdated
| @@ -1065,6 +1065,25 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Indentation is off on this one.
There was a problem hiding this comment.
Should be fixed now. Thanks!
junedkazi
approved these changes
Feb 24, 2017
junedkazi
suggested changes
Mar 13, 2017
| @@ -26,9 +26,11 @@ | |||
| - Remove an unnecessary and confusing option in theme editor [#927](https://github.com/bigcommerce/stencil/pull/927) | |||
| - Fix an issue where required product list options would display an invalid "none" choice [#929](https://github.com/bigcommerce/stencil/pull/929) | |||
| - Remove unused variable causing js error with search in the nav [#938](https://github.com/bigcommerce/stencil/pull/938) | |||
| - Add settings to theme editor schema to customize Optimized Checkout discount banners [#924](https://github.com/bigcommerce/stencil/pull/924) | |||
| - Add settings to theme editor schema to customize Optimized Checkout discount banners [#924] (https://github.com/bigcommerce/stencil/pull/924) | |||
There was a problem hiding this comment.
Not sure if this is a rebase gone wrong.
There was a problem hiding this comment.
Can you move your line to the bottom in the draft section
CHANGELOG.md
Outdated
| - Update Optimized Checkout discount banners default values per theme variation [#942](https://github.com/bigcommerce/stencil/pull/942) | ||
|
|
||
|
|
junedkazi
reviewed
Mar 13, 2017
| @@ -26,7 +27,7 @@ | |||
| - Remove an unnecessary and confusing option in theme editor [#927](https://github.com/bigcommerce/stencil/pull/927) | |||
| - Fix an issue where required product list options would display an invalid "none" choice [#929](https://github.com/bigcommerce/stencil/pull/929) | |||
| - Remove unused variable causing js error with search in the nav [#938](https://github.com/bigcommerce/stencil/pull/938) | |||
| - Add settings to theme editor schema to customize Optimized Checkout discount banners [#924](https://github.com/bigcommerce/stencil/pull/924) | |||
| - Add settings to theme editor schema to customize Optimized Checkout discount banners [#924] (https://github.com/bigcommerce/stencil/pull/924) | |||
There was a problem hiding this comment.
This looks wrong. Looks like there is a space.
cristycarpenter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a "Product display mode" setting to the theme editor so merchants can choose between a grid or list view for their products on category, brand, and search results pages. Product list view functionality already exists in the theme. This change allows merchants to actually use it :)
Tickets / Documentation
https://jira.bigcommerce.com/browse/STENCIL-3194
Screenshots (if appropriate)
Grid Mode (Default):
List Mode:
