Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHECKOUT-1189 : Adding support to Order Confirmation page in Stencil #949

Merged
merged 2 commits into from
Mar 13, 2017

Conversation

snaderiBC
Copy link
Contributor

@snaderiBC snaderiBC commented Mar 6, 2017

What?

  1. Adding Order Confirmation page to Themes so that along with Checkout page it can also be customized.
  2. Adding the feature customized_checkout to activate the feature for themes.
    I've excluded above to prevent any racing conditions when merging related PRs.
    After below PRs are merged, I'll create another PR with just the theme feature to prevent any unwanted issue in production.

Related PRs

https://github.com/bigcommerce-labs/ng-checkout/pull/394
https://github.com/bigcommerce/bigcommerce/pull/17826

Screenshots (if appropriate)

screen shot 2017-03-09 at 12 13 35 pm

@snaderiBC
Copy link
Contributor Author

Ping: @lord2800 @mcampa @icatalina @jordanwink201 for review

@mcampa
Copy link
Contributor

mcampa commented Mar 9, 2017

Please add a line to CHANGELOG.md file describing your change

@snaderiBC
Copy link
Contributor Author

Also, @mcampa I've named and renamed everywhere for the final page of check out to be Order Confirmation.
Looks like there have been already a page called order-complete.html. So, I suggest to remove that and replace it with what I've added to this PR so that it is consistent everywhere.
Also, is dash a convention? order-confirmation.html instead of orderconfirmation.html ?

Copy link
Contributor

@mcampa mcampa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@icatalina icatalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@snaderiBC snaderiBC merged commit 66fd524 into bigcommerce:master Mar 13, 2017
@snaderiBC snaderiBC deleted the CHECKOUT-1189 branch March 13, 2017 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants