Load amp social share only when we have icons to share. #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedkazi
force-pushed
the
fix-amp-social
branch
from
e25ac0f
to
d5af492
Compare
junedkazi
changed the title
mcampa
approved these changes
Mar 16, 2017
|
👍 |
junedkazi
force-pushed
the
fix-amp-social
branch
from
d5af492
to
aafee6b
Compare
junedkazi
force-pushed
the
fix-amp-social
branch
from
aafee6b
to
4cbdf79
Compare
|
Just a rebase to resolve changelog conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Load amp social share only when we have social icons.
Screenshots (if appropriate)
Before
After