Fix invalid icon HTML in AMP templates #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedkazi
approved these changes
Apr 4, 2017
There was a problem hiding this comment.
LGTM 👍 . Once @bookernath verifies it works we will merge this one.
bc-annavu
changed the title
|
💚 |
junedkazi
approved these changes
Apr 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
AMP is throwing validation errors based on some of the markup we use for our alert messages. We need to change the markup to use valid HTML tags and add in the styles for them since they were missing.
Screenshots (if appropriate)
@bookernath @junedkazi