STENCIL-3352 - Fix product quick view 'Write a Review' link #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedkazi
suggested changes
Apr 11, 2017
mjschock
commented
Apr 11, 2017
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## Draft | |||
| - Fix product quick view 'Write a Review' link [#995](https://jira.bigcommerce.com/browse/STENCIL-3352) | |||
There was a problem hiding this comment.
here you go @junedkazi
There was a problem hiding this comment.
The url should point to the PR not the jira ticket :)
There was a problem hiding this comment.
i have no idea what you're talking about :)
junedkazi
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug pointed out by @ocvninfo where clicking the 'Write a Review' link in the quick view would take you to the product page but would not open the modal.
Tickets / Documentation
Add links to any relevant tickets and documentation.
GIF with Fix
http://recordit.co/CS8jVePxfd/gif/notify
@bigcommerce/stencil-team