Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-3010 - Repopulate review form fields after error #996

Merged
merged 1 commit into from
Apr 18, 2017
Merged

STENCIL-3010 - Repopulate review form fields after error #996

merged 1 commit into from
Apr 18, 2017

Conversation

mjschock
Copy link
Contributor

What?

Fixes an issue where submitting an invalid form (usually because of the captcha) would result in the loss of the form data. For example, the comments might need to be re-entered.

Tickets / Documentation

GIF showing Fix

http://g.recordit.co/MhD8igg03S.gif

@bigcommerce/stencil-team

P.S. i opted for if/else's here for the sake of readability - i'm open to using an if subexpression in-line if people prefer that

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog

@mjschock
Copy link
Contributor Author

@junedkazi - changelog added

@mjschock mjschock merged commit 7bb7ef5 into bigcommerce:master Apr 18, 2017
@mjschock mjschock deleted the STENCIL-3010 branch April 18, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants