Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix latest node-sass issues with Citadel upgrade and conditional impo… #999

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Fix latest node-sass issues with Citadel upgrade and conditional impo… #999

merged 1 commit into from
Apr 25, 2017

Conversation

mjschock
Copy link
Contributor

…rt swap with mixin

What?

  • Fixes the two node-sass issues that were preventing upgrading node-sass:
    • Points to the latest version of Citadel which includes a fix to _tabs.scss.
    • Moves the conditional import of _clear-sans.scss to a conditional mixin inclusion instead

cc @bigcommerce/stencil-team

@mcampa
Copy link
Contributor

mcampa commented Apr 25, 2017

Add a changelog entry before merging it

@mjschock
Copy link
Contributor Author

changelog added, merging

@mjschock mjschock merged commit 9345aa0 into bigcommerce:master Apr 25, 2017
@mjschock mjschock deleted the SassFix branch April 25, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcampa mcampa mcampa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjschock @mcampa