Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing from cart and add Not Found UI #36

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

bc-yevhenii-buliuk
Copy link
Collaborator

@bc-yevhenii-buliuk bc-yevhenii-buliuk commented Dec 22, 2023

What?

This PR fixes the removal of items from the cart when using the "reduce quantity" button.
Also, this PR adds the display of the Not Found user interface on non-existing pages.

Screenshots/Videos

before

1760_bug.mov

after

1760_fix.mov

before

1760_error_not_found

after

1760_add_not_found_ui

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nextjs-commerce ✅ Ready (Inspect) Visit Preview Dec 22, 2023 3:07pm

Copy link
Collaborator

@bc-alexsaiannyi bc-alexsaiannyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bc-yevhenii-buliuk bc-yevhenii-buliuk changed the title fix removing from cart and add not-found ui Fix removing from cart and add Not Found UI Dec 22, 2023
Copy link
Collaborator

@yurytut1993 yurytut1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Collaborator

@BC-krasnoshapka BC-krasnoshapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BC-krasnoshapka BC-krasnoshapka merged commit b10fbb8 into main Dec 22, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants