Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test outlet temperature #187

Merged
merged 6 commits into from Dec 12, 2023
Merged

Write test outlet temperature #187

merged 6 commits into from Dec 12, 2023

Conversation

spahrenk
Copy link
Contributor

@spahrenk spahrenk commented Dec 8, 2023

Description

  • Enables writing the outlet temperature to test output files. This option is enabled by adding the entry "writeOutletT 1" to the file "testInfo.txt" for any test profile. The option is disabled by default. It was left disabled for all existing tests.
  • Entries are left blank when the flow is 0.
  • The option was tested manually for a few test profiles. If activated for a test, regression tests for that test will fail, unless reference files are changed. No influence on cse should be expected from these changes.

Author Progress Checklist:

  • Open draft pull request
    • Make title clearly understandable in a standalone change log context
    • Assign yourself the issue
    • Add at least one label (enhancement, bug, or maintenance)
    • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
  • Make code changes (if you haven't already)
  • Self-review of code
    • My code follows the style guidelines of this project
    • I have added comments to my code, particularly in hard-to-understand areas
    • I have only committed the necessary changes for this fix or feature
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have ensured that my fix is effective or that my feature works as intended by:
      • exercising the code changes in the test framework, and/or
      • manually verifying the changes (as explained in the the pull request description above)
    • My changes pass all local tests
    • My changes successfully passes CI checks
    • Add any unit test for proof and documentation.
    • Merge in main branch and address resulting conflicts and/or test failures.
  • Move pull request out of draft mode and assign reviewers
  • [] Iterate with reviewers until all changes are approved
    • Make changes in response to reviewer comments
    • Merge in main branch and address resulting conflicts and/or test failures.
    • Re-request review in GitHub

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved

@spahrenk spahrenk self-assigned this Dec 8, 2023
@spahrenk spahrenk marked this pull request as ready for review December 8, 2023 17:13
@@ -515,7 +515,7 @@ int HPWH::HPWHinit_presets(MODELS presetNum) {

else if (presetNum == MODELS_StorageTank) {
setNumNodes(12);
setpoint_C = 800.;
setpoint_C = F_TO_C(127.);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem relevant to this branch.

test/main.cc Outdated
Comment on lines 194 to 196
else if(var1 == "writeOutletT") {
writeOutletT = (bool)testVal;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be optional.

Copy link
Member

@nealkruis nealkruis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs the latest master merged in still, but otherwise good to go.

Comment on lines +272 to +274
CSVOPT_NONE = 0,
CSVOPT_IPUNITS = 1 << 0,
CSVOPT_IS_DRAWING = 1 << 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little weird, but since whether the system is drawing or not is a row-level property (not a whole CSV level property). It's not critical at this point to clean up this code, though.

@nealkruis nealkruis merged commit f9b8f77 into master Dec 12, 2023
2 checks passed
@nealkruis nealkruis deleted the write-outletT branch December 12, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants