Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HPWHsim to use btwxt v1.0.0 #189

Merged
merged 8 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ add_custom_target(${PROJECT_NAME}_version_header
)

set_target_properties(${PROJECT_NAME}_version_header PROPERTIES FOLDER Dependencies/HPWHsim)
include_directories("${PROJECT_BINARY_DIR}/src" "${PROJECT_SOURCE_DIR}/src")

set(headers
HPWHversion.in.hh
Expand All @@ -26,10 +25,13 @@ set(source
)
add_library(libHPWHsim ${source} ${headers})

target_include_directories(libHPWHsim PUBLIC ${PROJECT_BINARY_DIR}/src ${PROJECT_SOURCE_DIR}/src ${PROJECT_SOURCE_DIR}/vendor/btwxt/src)
chipbarnaby marked this conversation as resolved.
Show resolved Hide resolved

target_link_libraries( libHPWHsim PUBLIC btwxt)

add_dependencies(libHPWHsim ${PROJECT_NAME}_version_header)

set_target_properties(libHPWHsim PROPERTIES OUTPUT_NAME HPWHsim)
set_target_properties(libHPWHsim PROPERTIES PDB_NAME libHPWHsim)
target_compile_features(libHPWHsim PUBLIC cxx_std_17)

target_include_directories(libHPWHsim PUBLIC ${PROJECT_SOURCE_DIR}/vendor/btwxt/src)
2 changes: 1 addition & 1 deletion src/HPWH.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

#include "HPWH.hh"
#include "btwxt.h"
#include <btwxt/btwxt.h>

#include <stdarg.h>
#include <fstream>
Expand Down
2 changes: 1 addition & 1 deletion src/HPWHHeatSources.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include <regex>

// vendor
#include "btwxt.h"
#include <btwxt/btwxt.h>

#include "HPWH.hh"

Expand Down
14 changes: 11 additions & 3 deletions src/HPWHpresets.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ File Containing all of the presets available in HPWHsim
*/

#include "HPWH.hh"
#include "btwxt.h"
#include <btwxt/btwxt.h>

#include <algorithm>

Expand Down Expand Up @@ -1661,10 +1661,18 @@ int HPWH::HPWHinit_presets(MODELS presetNum) {
3.993147, 3.713376, 3.616836, 3.710957, 3.470484, 3.264466, 3.14959
});

// Set up regular grid interpolator.
// Set up regular grid interpolator.
#if 0
Btwxt::GriddedData gridded_data(compressor.perfGrid, compressor.perfGridValues);
gridded_data.set_axis_extrap_method(2, Btwxt::Method::LINEAR); //Linearly extrapolate on Tin (F)
compressor.perfRGI = new Btwxt::RegularGridInterpolator(gridded_data);
#endif
Btwxt::GridAxis g0(compressor.perfGrid[0], "TAir", Btwxt::InterpolationMethod::linear, Btwxt::ExtrapolationMethod::linear);
Btwxt::GridAxis g1(compressor.perfGrid[1], "TOut", Btwxt::InterpolationMethod::linear, Btwxt::ExtrapolationMethod::linear);
Btwxt::GridAxis g2(compressor.perfGrid[2], "TIn", Btwxt::InterpolationMethod::linear, Btwxt::ExtrapolationMethod::linear);
chipbarnaby marked this conversation as resolved.
Show resolved Hide resolved

std::vector<Btwxt::GridAxis> gx{ g0, g1, g2 };

compressor.perfRGI = new Btwxt::RegularGridInterpolator(gx, compressor.perfGridValues);
compressor.useBtwxtGrid = true;

compressor.secondaryHeatExchanger = { dF_TO_dC(10.), dF_TO_dC(15.), 27. };
Expand Down
2 changes: 1 addition & 1 deletion vendor/btwxt
Submodule btwxt updated 56 files
+64 −50 .clang-format
+59 −23 .github/workflows/build-and-test.yml
+5 −4 .gitignore
+6 −0 .gitmodules
+23 −23 CMakeLists.txt
+41 −57 README.md
+1 −1 cmake/compiler-flags.cmake
+231 −0 docs/figs/curve.svg
+ docs/figs/fig_2D_cubic.png
+ docs/figs/fig_2D_cubic_weights.png
+ docs/figs/fig_2D_linear.png
+ docs/figs/fig_cubic.png
+ docs/figs/fig_curve.png
+ docs/figs/fig_linear.png
+ docs/figs/fig_slope_est.png
+ docs/figs/fig_slopes.png
+ docs/figs/figs_all.pptx
+294 −0 docs/methodology.md
+10 −0 include/btwxt/CMakeLists.txt
+12 −0 include/btwxt/btwxt.h
+129 −0 include/btwxt/grid-axis.h
+34 −0 include/btwxt/grid-point-data.h
+39 −0 include/btwxt/logging.h
+143 −0 include/btwxt/regular-grid-interpolator.h
+23 −18 src/CMakeLists.txt
+0 −86 src/btwxt.cpp
+0 −110 src/btwxt.h
+0 −41 src/error.cpp
+0 −27 src/error.h
+135 −0 src/grid-axis.cpp
+0 −310 src/griddeddata.cpp
+0 −130 src/griddeddata.h
+0 −312 src/gridpoint.cpp
+0 −105 src/gridpoint.h
+547 −0 src/regular-grid-interpolator-implementation.cpp
+260 −0 src/regular-grid-interpolator-implementation.h
+251 −0 src/regular-grid-interpolator.cpp
+11 −15 test/CMakeLists.txt
+504 −0 test/btwxt-tests.cpp
+0 −226 test/btwxt_test.cpp
+0 −186 test/fixtures.hpp
+137 −0 test/fixtures/implementation-fixtures.h
+115 −0 test/fixtures/public-fixtures.h
+77 −0 test/grid-axis-tests.cpp
+0 −138 test/griddeddata_test.cpp
+0 −84 test/gridpoint_test.cpp
+0 −114 test/hypercube_test.cpp
+380 −0 test/implementation-tests.cpp
+0 −200 test/large_test.cpp
+0 −43 test/main_test.cpp
+0 −114 test/math_test.cpp
+11 −0 test/test-main.cpp
+13 −1 vendor/CMakeLists.txt
+1 −0 vendor/courierr
+1 −0 vendor/fmt
+1 −1 vendor/googletest