Should not accept an optional property with value null (unless null type) #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is my understanding that null values should be invalid, unless the
null
type is allowed. This matches (failing) examples like{"type": "string"}
withnull
on http://jsonschemalint.com/draft4/.However currently
This commit changes the behaviour to disallow
null
, removing code previously allowingnull
of the property was optional (maybe as specified in an older draft?).I have only added tests for
string
andinteger
types so far.