Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron cleanup #2

Closed
wants to merge 27 commits into from
Closed

Cron cleanup #2

wants to merge 27 commits into from

Conversation

bign8
Copy link
Owner

@bign8 bign8 commented Sep 8, 2015

Problem Cron is dirty code, difficult to understand, and lame!!
Solution Clean it up and do some cool pipelines stuff
Status Work In Progress

@codecov-io
Copy link

Current coverage is 8.77%

Merging #2 into master will decrease coverage by -0.15% as of 91237c3

@@            master     #2   diff @@
=====================================
  Files            2      2       
  Stmts           56     57     +1
  Branches         0      0       
  Methods          0      0       
=====================================
  Hit              5      5       
  Partial          0      0       
- Missed          51     52     +1

Review entire Coverage Diff as of 91237c3

Powered by Codecov. Updated on successful CI builds.

@bign8 bign8 marked this pull request as draft May 31, 2021 03:51
@bign8
Copy link
Owner Author

bign8 commented Jun 8, 2021

Re-reviewing this and trying to catch up on context that I've long since forgotten 6 years ago... there are a few good things hidden in here:

  • Using the 75th percentile to limit the tags returned to the user list Percentile based tag culling #36
  • Special logic to determine if images appear in multiple posts (might be the whole "graph" thing... neat, but 🤷)
  • Splitting the cron to run on a backend instance (instead of a frontend) Move Cron to B1 Instance #35
  • Sharded blob storage driver (for storing >1mb blobs in datastore)... please... don't do this... ever (use S3 or a Bucket)

This was referenced Jun 8, 2021
@bign8
Copy link
Owner Author

bign8 commented Jun 8, 2021

I've quickly reviewed this (6 years later) and the underlying code seems to have changed sufficiently enough to invalidate this. The things that should be kept around (imo) have been converted into issues, otherwise, lets close this bad boy.

@bign8 bign8 closed this Jun 8, 2021
@bign8 bign8 mentioned this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants