Implement Unpacker #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go does not have a way to detect if a key is present but assigned null.
To work around this, <field>Null booleans were added to `Transforms`.
Custom serialization logic that uses a generic `map[string]interface{}`
then sets these feilds appropriately using `v, ok := map[key]`.
Note: Supplementary-2 and 3 needed manual updating to match my expectations. Still waiting discussion in the NumTechnology Slack, but just getting things moving for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NUM Community has officially released the Unpacker specification! This PR adds the ability to unpack JSON objects using Transforms, Substitutions and Variadic Indexes.
This implementation has a few changes that are not consistent with unpacker.uk/playground's interactions.
null+assignKeysandreplacePair[slack]0+falseresolving asnulland{}being resolved as[object Object][slack]%var%%%%var%not resolving asvar%var[slack]