Skip to content
This repository has been archived by the owner on Sep 19, 2018. It is now read-only.

Implementing decimal support #247

Closed
adotor opened this issue Mar 14, 2017 · 1 comment
Closed

Implementing decimal support #247

adotor opened this issue Mar 14, 2017 · 1 comment

Comments

@adotor
Copy link

adotor commented Mar 14, 2017

Hi,

last week I stumbled upon an issue regarding the encoding/decoding of floating point values. As far as I can see I have to deal with all the accuracy problems of Doubles when it comes to floating point values in the current implementation.

Therefore I tried to implement the support of Decimal for encoding and decoding as contribution. Encoding went well, but when it comes to Decoding the solution is not that straightforward.

After looking into the JSONParser I understand that the parser itself is using Doubles when it comes to parsing floating point numbers.

Has anyone thought of a strategy to improve the handling of floating point numbers in Freddy yet?

Kind regards,
Alexander

@davidahouse davidahouse self-assigned this Oct 15, 2017
@bignerdranch bignerdranch deleted a comment from davidahouse Jun 2, 2018
@zwaldowski
Copy link
Contributor

Unfortunately, after a few attempts on our end the decoding path isn't well-defined without breaking existing clients. Freddy is in maintenance mode and only seeking to make bug fixes at the moment. Please reopen if you have more thoughts on an implementation. Thanks for the suggestion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants