Use callbacks instead of return values

bigodines · Oct 2, 2012 · dab2276 · dab2276
1 parent ed039aa
commit dab2276
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/storage/ff_redis.js b/storage/ff_redis.js
@@ -6,7 +6,7 @@
       /* public methods*/
       return {
         set: function (key, value, cb) {
-          return redis.set(key, value, function (err, data) {
+          redis.set(key, value, function (err, data) {
             if (!cb) {
               return;
             }
@@ -23,7 +23,7 @@
 
         },
         del: function (key, cb) {
-          return redis.del(key, cb);
+          redis.del(key, cb);
         }
       };
     };

diff --git a/test/redis_test.js b/test/redis_test.js
@@ -7,8 +7,8 @@ describe('Redis Storage', function() {
     describe('Basic Stuff', function() {
         var serialized_object = "{ 'foo' : 'bar', 'john' : 'doe' }";
         it('should be able to take a JSON and save', function(done) {
-            var result = storage.set('id', serialized_object, function (err, data) {
-                result.should.equal(true);
+            storage.set('id', serialized_object, function (err, data) {
+                should.equal(err, null);
                 done();
             });
 
@@ -24,13 +24,13 @@ describe('Redis Storage', function() {
 
         it('should be able to delete', function(done) {
             storage.set('foo', 'foo_value');
-            var result = storage.del('foo')
-            result.should.equal(true);
-            storage.get('foo', function(err, data) {
-                should.equal(data, null);
-                done();
+            storage.del('foo', function (err) {
+                should.equal(err, null);
+                storage.get('foo', function(err, data) {
+                    should.equal(data, null);
+                    done();
+                });
             });
-
         });
 
     });