Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minishell norminette 처리 #3

Merged
merged 1 commit into from Jan 1, 2022
Merged

minishell norminette 처리 #3

merged 1 commit into from Jan 1, 2022

Conversation

guswns8431
Copy link
Contributor

parse/expand_2.c line.101
*iter를 *it로 줄여서 처리할까 하다가 일단은 예쁘진 않지만 행을 나누는 것으로 80자 초과 처리했습니다

astree/frag_1.c line.68, 70, 72
한 줄에 선언 두 개가 문제가 되는 거 같습니다. frag->type, frag->exec를 초기화 해주는 함수를 따로 만들어줄까 생각해봤고 다른 방법이 있을까 하여 수정은 하지 않은 상태입니다.

그 이외는 공백, tab 등 단순 norminette 처리 완료했습니다

@bigpel66 bigpel66 linked an issue Jan 1, 2022 that may be closed by this pull request
@bigpel66 bigpel66 added the help wanted Extra attention is needed label Jan 1, 2022
@bigpel66 bigpel66 self-requested a review January 1, 2022 03:36
@bigpel66 bigpel66 merged commit 0b68e62 into bigpel66:main Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minishell norminette 처리
2 participants