Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.localStorage needs to be wrapped in try catch on safari Closes: #4 #9

Merged
merged 1 commit into from
Jan 29, 2020
Merged

window.localStorage needs to be wrapped in try catch on safari Closes: #4 #9

merged 1 commit into from
Jan 29, 2020

Conversation

sulmanen
Copy link

@sulmanen sulmanen commented Sep 3, 2019 •
edited

Fixes #4

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 87.931% when pulling 4ffb20f on Yleisradio:fix/safari-local-storage-block-all-cookies into f663c23 on bigpipe:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 87.931% when pulling 4ffb20f on Yleisradio:fix/safari-local-storage-block-all-cookies into f663c23 on bigpipe:master.

@sulmanen sulmanen changed the title window.localStorage needs to be wrapped in try catch on safari window.localStorage needs to be wrapped in try catch on safari Closes: #4 Nov 7, 2019
@3rd-Eden 3rd-Eden merged commit 44040bf into 3rd-Eden:master Jan 29, 2020
@3rd-Eden
Copy link
Owner

3rd-Eden commented Jan 29, 2020 •
edited

This somehow slipped my radar :/ merged and published in a sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.0.4 no longer works in an IFrame with third-party cookies disabled.
3 participants
@sulmanen @coveralls @3rd-Eden