Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.0.4 no longer works in an IFrame with third-party cookies disabled. #4

Closed
Jasu opened this issue Aug 6, 2018 · 1 comment · Fixed by #9
Closed

0.0.4 no longer works in an IFrame with third-party cookies disabled. #4

Jasu opened this issue Aug 6, 2018 · 1 comment · Fixed by #9

Comments

@Jasu
Copy link

Jasu commented Aug 6, 2018

If third-party cookies are disabled on Chrome, the following line will throw a DOMException SecurityError:

    if (window.localStorage) {

This should probably be wrapped in a try-catch-block, like in 0.0.3.
@Jasu Jasu changed the title 0.0.4 no longer works in an IFrame with third-party cookies are disabled. 0.0.4 no longer works in an IFrame with third-party cookies disabled. Aug 6, 2018
@cephalopodMD
Copy link

cephalopodMD commented Aug 7, 2019 •
edited
Loading

This also repros in incognito mode with 3rd party cookies disabled. @3rd-Eden please fix this by either accepting #8 or #7. Consumers of this package shouldn't have to know to specify version 0.0.3.

@sulmanen sulmanen mentioned this issue Nov 7, 2019
Merged
3rd-Eden added a commit that referenced this issue Jan 29, 2020
@3rd-Eden
Merge pull request #9 from Yleisradio/fix/safari-local-storage-block-…
44040bf 
…all-cookies

window.localStorage needs to be wrapped in try catch on safari Closes: #4
3rd-Eden added a commit that referenced this issue Jan 29, 2020
@3rd-Eden
[test] adding test case against #4
9343fd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

window.localStorage needs to be wrapped in try catch on safari Closes: #4 Yleisradio/env-variable
2 participants
@Jasu @cephalopodMD