Nakamori as video library source

[bigretromike]

This is very possible, this is something quite new, and no-one did it before.

xbmc/xbmc#13566
xbmc/xbmc#14210

I did somehow be able to make it work once, and then after cleaning library it broken - from last 8h I spend on this it looks like Library is buggy (and when cached something and remove it it still hold something for it, that would explain why it was working all the time until I wipe Library.db), like when you add something and it does scan, after many attempts and edits its start to throw errors like the path is not there. And I was hoping to make it without initially announcing it - but looks like I'm just a human.

When It did worked and added series it worked very well - with exception of missing few infos.

I came to conclusion that with all those custom object its utterly hared to do anything like this for me - and without proper IDE most of the time.

Currently its skips all the Series, the only thing is does scan are those extra menus if you add them to tvshow path. Which is strange.

I can be probably something trivial that I don't see, so fell free if you have spare time @da3dsoul to mess with this, as for now its not working.

I understand the cons of using nakamori as video source but I also see the potential and benefits for supporting this - this is far superior than any scraper for Shoko could be.

easy and dirty instruction is to add video source as plugin://plugin.video.nakamori/tvshows/<apikey>/, pick TV shows and Local information only in Set Content, double check if Selected folder contains a single TV show is uncheck and hit ok.

[bigretromike]

I would be glad if @AkariDN had a time to look it up, as he is the author of those awesome commits about this.

[da3dsoul]

Well, following general Kodi and development guidelines. Please attach a debug log of Kodi when trying to do this.

Can you make a new repo plugin.videosource.nakamori? I don't know if there's a convention yet, but that sounds decent. We can move it into a new plugin so it's easy to enable and disable, as well as having its code unique to it, rather than plugin, which provides menus.

[bigretromike]

You suppost to make seperate path in video plugin 😃 not seperate plugin

…

On April 5, 2019 3:25:38 PM GMT+02:00, da3dsoul ***@***.***> wrote: Well, following general Kodi and development guidelines. Please attach a debug log of Kodi when trying to do this. Can you make a new repo plugin.videosource.nakamori? I don't know if there's a convention yet, but that sounds decent. We can move it into a new plugin so it's easy to enable and disable, as well as having its code unique to it, rather than plugin, which provides menus. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #306 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[da3dsoul]

Then how do you turn it off?

[da3dsoul]

Not everyone wants 45000 anime episodes in their collection of American Cartoons from the early 2000s

[bigretromike]

You remove video source from library

…

On April 5, 2019 3:47:00 PM GMT+02:00, da3dsoul ***@***.***> wrote: Then how do you turn it off? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #306 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[bigretromike]

If you never used library in kodi there are screenshots in first commit in first post

…

On April 5, 2019 3:48:15 PM GMT+02:00, da3dsoul ***@***.***> wrote: Not everyone wants 45000 anime episodes in their collection of American Cartoons from the early 2000s -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #306 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[da3dsoul]

Ah I see.

[da3dsoul]

oh....I need a nightly haha

[da3dsoul]

I see one issue right off the bat. I'll see if I can get it working nicely.

[da3dsoul]

@bigretromike don't feel bad. You found a bug...

@AkariDN The way to reproduce this issue (on latest nightly, 4/4/2019) is to make a URL pattern, for example plugin://plugin.video.nakamori/tvshows/12/ep/4, change it to something else, ex plugin://plugin.video.nakamori/tvshows/series/12/ep/4. When you enter the plugin, even from the Files menu, then it goes to the correct new URL. If you try to scan it, then it uses the old one, no matter what the code says. I'm looking into the db3 files next to see if I can find it.

EDIT: Verified. MyVideos116.db -> tables -> path is not updated, and it is used before trying the new URL.

[da3dsoul]

kodi.log
Here's a debug log. It doesn't say anything helpful, though...

[da3dsoul]

I'm having trouble getting anything to show up. If I enter the menus, then they all appear as expected, but the scan returns nothing.

[bigretromike]

I see you manage to find more than I did. The fun part is that if you type source as plugin://plugin.video.nakamori/ and you scan it you can see in top right cornet that it iterate over Search, Continue watching, etc (and see that search box apears, info box etc) its funny because I used filter_id=1 which gave me Continue watching and when it worked it did iterate over series and in right top corner there was full names of those series and later they would be added.

Later I was thinking that maybe /tvshow/ path in addon.xml is limiting it because it would enter tshows list items as url=/menu/series/<id> but from time to time when I change the code like chaning DirectoryList or ListItem to native xbmc object, or when I added other menus there I would see that it does enter into those episodes and most of the time hit /episode/types.

Funny how it work that one time because it was broken

The only thing you need to remember (but it looks like you know more than I did in 3 days) that when you use it a source for library it wont and CAN'T access settings - thats why some logic dont work.

The original idea was that I would anchor it on /tvshows/ that would list all items from All and it would flat the types and show only episodes and special. Funny enough when I did work it worked quite well it automaticly made Seasons for JoJo, proper naming etc....

But with the clue you found out about Library bugged not using url that would make sense because when I added it first I did change url many times, also I don't know if it should work on scaning for new content (from context menu) or it should be only tested from removing item, cleaning library, source.xml and then reading because other way it remembers settings etc.

I knew you will dig more in few hours than I did in few days, and it frustrating that we are 'thiiiis' close to solve it.

Hope its not another bug like the plugin_routing had.... ^_^

[bigretromike]

Before I would add tones of xbmc.log() in every path that I would think it goes and see in log where did he scan those files. Thats a good indicator what those it see.

And It does see each extra_menu from add_extra_menu (calendar, search, experiment) but refuse to see series which are kodi_models.ListItems inside DirectoryList. Thats why I wanted dump those, to compare because that could be something with that.

The last this is that I did try once (before it worked) with li.setProperty('get_stream_details_from_player', 'true') dunno if that helped or not, because I removed it later - but maybe it did (maybe its a clue).

But with the way Library is bugged the best way to test would be each time wipe clean kodi library and settings.... which would take ages.. or use container hahaha...

I'm just wishing that somehow we (You) manage to overcome this bug, because that would make a Nakamori even more useful.

Oh, the last thing I remember when It used to work, was that files wouldn't worked but I was thinking it was because lack of settings (because items added to library dont have settings), other than that I could list them by Title, Year, etc. Oh and I had issue with marking them as played that's why I was tweaking with countplay and later with studio.

The last time it worked was when I added the xbmc.log() to your error handler class. And it worked because each time I 'scanned' source it would throw those errors that '3' is not in empty list. But acording to what you wrote and what I tested It was long gone broken and yet Library worked because it was using old cached data, and would iterate over Library items and not the one from plugin.

[da3dsoul]

That might help, actually

[da3dsoul]

I think I got it. You can't map more than one episode to a single one by the numbers.

[da3dsoul]

Stream info doesn't appear to be working, but that may be because I forgot to add it...IDK I've been trying a lot.

[da3dsoul]

Fixed the stream info and cleaned it up. All that's left is checking for existence (cleaning DB) and maybe that hash thing.

[da3dsoul]

Psh long term. How about now?

[da3dsoul]

Okay, movies don't work at all. I'm working on extendedinfoscript quirks, but it's kind of working.

[da3dsoul]

A way to improve it would be to get all images from the API, rather than the random ones we would get for the plugin menus.

[bigretromike]

I don't belive

…

On April 6, 2019 1:54:45 PM GMT+02:00, da3dsoul ***@***.***> wrote: I think I got it. You can't map more than one episode to a single one by the numbers. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #306 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[bigretromike]

OMG will try it in 1-2 h

…

On April 6, 2019 2:32:03 PM GMT+02:00, da3dsoul ***@***.***> wrote: Psh long term. How about now? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #306 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[bigretromike]

That would make sense because we use playcount already. Thanks !

[bigretromike]

@AkariDN do you recall adding something to JSON-RPC to make files added from plugin source could be accessed by it ?
I'm sending this command:

{"jsonrpc":"2.0","method":"Files.GetFileDetails","params":{"file":"plugin://plugin.video.nakamori/tvshows/98939/play", "properties": ["episode", "title", "uniqueid", "tvshowid"]},"id":1}

I tried with file: plugin://plugin.video.nakamori/plugin://plugin.video.nakamori/tvshows/98939/play because in db the files are saved with as strPath = plugin://plugin.video.nakamori/tvshows/98939/play
while path linked to it is strPath = plugin://plugin.video.nakamori/ so I combine them, yet the kodi throw at me this kind of error:

2019-04-10 13:39:09.492 T:12520  NOTICE: {"jsonrpc":"2.0","method":"Files.GetFileDetails","params":{"file":"plugin://plugin.video.nakamori/tvshows/98939/play", "properties": ["episode", "title", "uniqueid", "tvshowid"]},"id":1}
2019-04-10 13:39:09.493 T:12520 WARNING: XFILE::CFileFactory::CreateLoader - unsupported protocol(plugin) in plugin://plugin.video.nakamori/tvshows/98939/play
2019-04-10 13:39:09.493 T:12520  NOTICE: {"error":{"code":-32602,"message":"Invalid params."},"id":1,"jsonrpc":"2.0"}

I print the command that I send that's why its there.

I'm not sure if this is not because the plugin was used as source so kodi now can't combine proper file path and searching by full_path_name is broken.

[AkariDN]

Plugin URLs are not supported by this function:

JSONRPC_STATUS CFileOperations::GetFileDetails(const std::string &method, ITransportLayer *transport, IClient *client, const CVariant &parameterObject, CVariant &result)
{
  std::string file = parameterObject["file"].asString();
  if (!CFile::Exists(file))
    return InvalidParams;
...

[bigretromike]

Any chance you could make it work ? or any idea how to retrive db_id for item that I have full path to file that was added to db ?!
I would like to sync Library with Plugin for those who would like to use plugin on one Kodi and Library source on other.

[AkariDN]

Unfortunately currently I have no time for this. Create an issue in Kodi repository, I hope somebody fix it.

I'm not an expert in Kodi jsonrpc, maybe there is some easier way except this:

• Export your tvshows from plugin with 'tag' and 'uniqueid' properties (e.g. tag = Nakamori, uniqueid = tvshow/episode id)
• Use VideoLibrary.GetTVShows and find 'tvshowid' by 'uniqueid'
  {"jsonrpc": "2.0", "id": 1, "method": "VideoLibrary.GetTVShows", "params": {"properties": ["uniqueid"], "filter": {"tag": "Nakamori"}}}
• Use VideoLibrary.GetEpisodes and find 'episodeid' by 'uniqueid'
  {"jsonrpc": "2.0", "id": 1, "method": "VideoLibrary.GetEpisodes", "params": {"tvshowid": 1, "properties": ["uniqueid"]}}

[bigretromike]

No problem. Will do ! Also I will check that workaround

…

On April 11, 2019 5:16:42 AM GMT+02:00, AkariDN ***@***.***> wrote: Unfortunately currently I have no time for this. Create an issue in Kodi repository, I hope somebody fix it. I'm not an expert in Kodi jsonrpc, maybe there is some easier way except this: * Export your tvshows from plugin with 'tag' and 'uniqueid' properties (e.g. tag = Nakamori, uniqueid = tvshow/episode id) * Use VideoLibrary.GetTVShows and find 'tvshowid' by 'uniqueid' `{"jsonrpc":"2.0", "id":1, "method":"VideoLibrary.GetTVShows","params":{"properties": ["uniqueid"], "filter": {"tag": "Nakamori"}}}` * Use VideoLibrary.GetEpisodes and find 'episodeid' by 'uniqueid' ```{"jsonrpc":"2.0", "id":1, "method":"VideoLibrary.GetEpisodes","params":{"tvshowid": 1, "properties": ["uniqueid"]}}``` -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #306 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[da3dsoul]

Akari how dare you! Devs aren't allowed to have basic human needs, let alone lives! Do we need to take you to the White Room for educating?

[bigretromike]

I clean up as this is going to be linked.

I made and Issue: xbmc/xbmc#15897 not sure if I describe it the way it should be describe. Finger cross that someone pick that up and make fix for Leia.

[bigretromike]

@AkariDN hey, any idea why it throws this king of error for every tvshow that is being added to Video Library ?

2019-04-15 13:55:01.865 T:7140   ERROR: CScraperParser::Parse: Could not find scraper function GetArt
2019-04-15 13:55:01.865 T:7140   ERROR: ADDON::CScraper::Run: Unable to parse web site
2019-04-15 13:55:01.882 T:7140 WARNING: XFILE::CFileFactory::CreateLoader - unsupported protocol(plugin) in plugin://plugin.video.nakamori/tvshows/807

We use setArt() for our ListItems, but do we need to write some custom function GetArt or something?

[bigretromike]

Our lord and savior @AkariDN did push fix that end-up in kodi 18.2
While mine issues weren't resolved its a still nice thing to have.

without Files.GetFileDetails fix we can't sync watch from shoko to library after import it's still a stable thing.

So we having a great functionality for 18.2+

[da3dsoul]

We might be able to with DB hacks similar to that watched state manager I've seen but never used

[bigretromike]

or if you are able to fix the shit inside kodi c++ code from issue I made :P and then I can make it work with proper API call ;p

[bigretromike]

Waiting for approval: xbmc/xbmc#16087
Until then this is really hard (or by somekind of funky/hacky workaround)

[bigretromike]

I'm still waiting for them to review my patch, I will announce this feature as part of 3.3.0 maybe we will have working sync between both.

@da3dsoul you said about some DB hacks, still got them ?

Im moving this to 3.3.0;

[bigretromike]

As this is possible in 18. (will probably need to add that in notes), I don't think that sync will be possible before 19.0, so moving this to 19.x

[bigretromike]

Once again I would like to thank you @AkariDN - your work was a game changer for me :-) thanks.

Also:

• Update Library work fine
• Sync Plugin flags with VideoLibrary flags