Optimize RemoteSequenceManager #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justheuristic
changed the title
borzunov
reviewed
Dec 1, 2022
| @@ -0,0 +1 @@ | |||
| """Client-side functions responsible for choosing the best server, """ | |||
There was a problem hiding this comment.
Suggested change
| """Client-side functions responsible for choosing the best server, """ | |
| """Client-side functions responsible for choosing the best server.""" |
borzunov
reviewed
Dec 1, 2022
borzunov
reviewed
Dec 1, 2022
| start=True, | ||
| ) | ||
|
|
||
| def trigger_update(self): |
There was a problem hiding this comment.
Let's rename:
- (optional)
trigger_update()->update()(maybe withwait=True/False) update_()->_update()(it's a private method, a user can't call it because it's not thread-safe)
borzunov
reviewed
Dec 1, 2022
borzunov
reviewed
Dec 1, 2022
| logger.debug(f"{self.__class__.__name__} is shutting down") | ||
| break | ||
|
|
||
| if not self.trigger.is_set() and time.perf_counter() - self.last_update_time >= self.update_period: |
There was a problem hiding this comment.
Suggested change
| if not self.trigger.is_set() and time.perf_counter() - self.last_update_time >= self.update_period: | |
| if not self.trigger.is_set(): |
Simplify
borzunov
reviewed
Dec 1, 2022
| finally: | ||
| del update_manager | ||
|
|
||
| logger.info(f"{self.__class__.__name__} thread exited") |
There was a problem hiding this comment.
Suggested change
| logger.info(f"{self.__class__.__name__} thread exited") | |
| logger.debug(f"{self.__class__.__name__} thread exited") |
(not useful to the end user)
borzunov
reviewed
Dec 1, 2022
| def update_(self): | ||
| """Perform an immediate and synchronous refresh, may take time""" | ||
| for attempt_no in itertools.count(): | ||
| new_block_infos = petals.dht_utils.get_remote_module_infos( |
There was a problem hiding this comment.
Please wrap this in try-except, so retry happens in except
E.g., if the client has a network outage, get_remote_module_infos will fail but we still want to retry
borzunov
reviewed
Dec 1, 2022
| self.dht, self.block_uids, expiration_time=float("inf"), frozen=False | ||
| ) | ||
| with self.lock_changes: | ||
| self.sequence_info.update_(new_block_infos) |
There was a problem hiding this comment.
I'm worried that it is not updated with OFFLINEs
borzunov
reviewed
Dec 1, 2022
# Conflicts: # src/petals/client/remote_sequential.py # src/petals/client/sequence_manager.py # src/petals/client/sequential_autograd.py
Merged
justheuristic
added a commit
that referenced
this pull request
Dec 1, 2022
Fix an issue in span selection that was introduced in #106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the time this text is copied to commit message, this PR will have
traceback
4review: