-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local tensor-parallel fwd/bwd #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Iaroslav Lisniak <48571134+IaroslavLisniak@users.noreply.github.com> Co-authored-by: Iaroslav Lisniak <yalisnyak@nes.ru> Co-authored-by: Andrei Panferov <andrei@blacksamorez.ru> Co-authored-by: Andrei Panferov <andrei.panferov@eqvilent.com>
Co-authored-by: Iaroslav Lisniak <48571134+IaroslavLisniak@users.noreply.github.com> Co-authored-by: Iaroslav Lisniak <yalisnyak@nes.ru> Co-authored-by: Andrei Panferov <andrei@blacksamorez.ru> Co-authored-by: Andrei Panferov <andrei.panferov@eqvilent.com>
Co-authored-by: Iaroslav Lisniak <48571134+IaroslavLisniak@users.noreply.github.com> Co-authored-by: Iaroslav Lisniak <yalisnyak@nes.ru> Co-authored-by: Andrei Panferov <andrei@blacksamorez.ru> Co-authored-by: Andrei Panferov <andrei.panferov@eqvilent.com>
Co-authored-by: Iaroslav Lisniak <48571134+IaroslavLisniak@users.noreply.github.com> Co-authored-by: Iaroslav Lisniak <yalisnyak@nes.ru> Co-authored-by: Andrei Panferov <andrei@blacksamorez.ru> Co-authored-by: Andrei Panferov <andrei.panferov@eqvilent.com>
Co-authored-by: Iaroslav Lisniak <48571134+IaroslavLisniak@users.noreply.github.com> Co-authored-by: Iaroslav Lisniak <yalisnyak@nes.ru> Co-authored-by: Andrei Panferov <andrei@blacksamorez.ru> Co-authored-by: Andrei Panferov <andrei.panferov@eqvilent.com>
Co-authored-by: Iaroslav Lisniak <48571134+IaroslavLisniak@users.noreply.github.com> Co-authored-by: Iaroslav Lisniak <yalisnyak@nes.ru> Co-authored-by: Andrei Panferov <andrei@blacksamorez.ru> Co-authored-by: Andrei Panferov <andrei.panferov@eqvilent.com>
justheuristic
commented
Jan 3, 2023
src/petals/server/backend.py
Outdated
@@ -48,44 +64,60 @@ def __init__(self, *args, memory_cache: MemoryCache, backend_dtype: torch.dtype, | |||
self.kwargs_schema, | |||
) | |||
|
|||
def get_inference_cache_descriptors(self, batch_size: int, max_length: int) -> Tuple[TensorDescriptor, ...]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be more than 2 tuples if TP > 1
borzunov
reviewed
Jan 3, 2023
borzunov
reviewed
Jan 3, 2023
Co-authored-by: Alexander Borzunov <borzunov.alexander@gmail.com>
Co-authored-by: Alexander Borzunov <borzunov.alexander@gmail.com>
borzunov
reviewed
Jan 3, 2023
Co-authored-by: Alexander Borzunov <borzunov.alexander@gmail.com>
borzunov
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an option to run Petals server on multiple local GPUs. It uses https://github.com/BlackSamorez/tensor_parallel
Benchmark
https://gist.github.com/justheuristic/149ccfbf903a847cbaa09dbe59965bd9
Overnight sanity checks:
>=
80% GPU utilization with 3x 1080ti, batch = 8 tokens