Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OOMs happening in case of accelerate >= 0.16.0 #310

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

borzunov
Copy link
Collaborator

@borzunov borzunov commented Apr 25, 2023

@borzunov borzunov requested a review from mryab April 25, 2023 11:31
Copy link
Member

@mryab mryab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick investigation!

@@ -33,7 +33,7 @@ python_requires = >=3.7
install_requires =
torch>=1.12
bitsandbytes==0.38.0.post2
accelerate>=0.15.0,<1.0.0
accelerate>=0.16.0,<1.0.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_module_tensor_to_device's dtype arg didn't exist before 0.16.0

@borzunov borzunov changed the title Fix OOMs caused by dtype in load_pretrained_block() Fix OOMs happened with accelerate >= 0.16.0 Apr 25, 2023
@borzunov borzunov changed the title Fix OOMs happened with accelerate >= 0.16.0 Fix OOMs happened in case of accelerate >= 0.16.0 Apr 25, 2023
@borzunov borzunov changed the title Fix OOMs happened in case of accelerate >= 0.16.0 Fix OOMs happening in case of accelerate >= 0.16.0 Apr 25, 2023
@borzunov borzunov merged commit 454c193 into main Apr 25, 2023
8 checks passed
@borzunov borzunov deleted the from-pretrained-dtype branch April 25, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants