New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warmup steps and minor issues in benchmarks #334

Merged

borzunov merged 3 commits into main from fix-benchmarks

Jun 30, 2023

Collaborator

borzunov commented Jun 29, 2023 •

edited

The previous code was incorrect for the case of warmup_steps != 1 (this mode was never used, but can be used in future).

borzunov added 3 commits

June 29, 2023 23:28


          Set use_fast=False for tokenizer

bc28018


          Account for warmup steps correctly

a4c8f86


          Add warmup steps to --n_steps

1f9319f

borzunov merged commit 10c72ac into main

7 checks passed

borzunov deleted the fix-benchmarks branch

June 30, 2023 00:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment