Allow free_disk_space_for() remove arbitrary files from Petals cache #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
commented
Jul 5, 2023
| @@ -33,15 +33,12 @@ def allow_cache_reads(cache_dir: Optional[str]): | |||
| return _blocks_lock(cache_dir, fcntl.LOCK_SH) | |||
|
|
|||
|
|
|||
| def allow_cache_writes( | |||
| cache_dir: Optional[str], *, reserve: Optional[int] = None, max_disk_space: Optional[int] = None | |||
| ): | |||
There was a problem hiding this comment.
These were some unused args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
free_disk_space_for()was able to remove (a) only entire cached revisions (= git commits/branches) and (b) only from the repository we're loading right now.This PR allows this functions to remove arbitrary files separately from any repositories.
This is useful for transition to Petals 1.2.0+, since it now uses original repos instead of the ones with converted models (see #323). In particular, the cache for
bigscience/bloom-petalsis now deprecated and should be removed in favor ofbigscience/bloom. This is also useful as a way to free space before loading LoRA adapters (#335).