Use bnb==0.40.0.post4 to fix bias bug, use bfloat16 by default #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/petals/server/server.py
Outdated
| if self.block_config.model_type == "llama" and torch_dtype == torch.bfloat16 and quant_type != QuantType.NF4: | ||
| logger.warning( | ||
| "LLaMA is loaded in bfloat16 for compatibility with --quant_type nf4 servers (default). " | ||
| "If you use a private swarm without such servers, use --torch_dtype float16 to force the original float16 dtype" |
There was a problem hiding this comment.
Suggested change
| "If you use a private swarm without such servers, use --torch_dtype float16 to force the original float16 dtype" | |
| "If you want to run in float16, use --torch_dtype float16 to force the original float16 dtype" |
src/petals/server/server.py
Outdated
| @@ -173,6 +173,12 @@ def __init__( | |||
| self.quant_type = quant_type | |||
| logger.info(f"Model weights are loaded in {get_dtype_name(torch_dtype, quant_type)} format") | |||
|
|
|||
| if self.block_config.model_type == "llama" and torch_dtype == torch.bfloat16 and quant_type != QuantType.NF4: | |||
| logger.warning( | |||
| "LLaMA is loaded in bfloat16 for compatibility with --quant_type nf4 servers (default). " | |||
There was a problem hiding this comment.
Suggested change
| "LLaMA is loaded in bfloat16 for compatibility with --quant_type nf4 servers (default). " | |
| "LLaMA is loaded in bfloat16 for compatibility with Guanaco nf4 setup (default). " |
justheuristic
approved these changes
Jul 12, 2023
borzunov
force-pushed
the
fix-nf4-and-dtypes
branch
from
5d434a1
to
f53c581
Compare
|
Transition to bfloat16 has been delayed due to bnb performance issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: