Test that bitsandbytes is not imported when it's not used #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
commented
Jul 14, 2023
| @@ -43,7 +43,7 @@ def test_sequence_manager_basics(mode: str): | |||
| assert shutdown_evt.is_set() | |||
|
|
|||
|
|
|||
| class TestSequenceManager(RemoteSequenceManager): | |||
| class RemoteSequenceManagerWithChecks(RemoteSequenceManager): | |||
There was a problem hiding this comment.
pytest thinks that classes whose name starts with Test are test cases and raises warnings during test collection. Fixing that.
artek0chumak
approved these changes
Jul 14, 2023
borzunov
force-pushed
the
test-bnb-not-imported
branch
from
d35fa29
to
b4e8faf
Compare
borzunov
force-pushed
the
test-bnb-not-imported
branch
from
b4e8faf
to
772eca6
Compare
borzunov
commented
Jul 14, 2023
| @@ -33,7 +33,7 @@ python_requires = >=3.7 | |||
| install_requires = | |||
| torch>=1.12 | |||
| bitsandbytes==0.40.0.post4 | |||
| accelerate>=0.16.0,<1.0.0 | |||
| accelerate>=0.16.0,<0.21.0 | |||
There was a problem hiding this comment.
accelerate 0.21.0 released yesterday imports bnb automatically if it's installed :( Maybe this will change in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoid importing bitsandbytes when it's not used, since bitsandbytes doesn't always find correct CUDA libs and may raise exceptions because of that.