Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority tasks #47

Merged
merged 40 commits into from
Sep 10, 2022
Merged

Priority tasks #47

merged 40 commits into from
Sep 10, 2022

Conversation

GreenFatGuy
Copy link
Collaborator

@GreenFatGuy GreenFatGuy commented Aug 21, 2022

Here we implement first version of "financial" side of the cooperation in petals
TODO:

  • Tests

@justheuristic
Copy link
Collaborator

Logging conversation with @GreenFatGuy and @borzunov

right before merge

  • TODO rename Bank , e.g. SpendingPolicy
  • TODO rename Broker TaskAppraiser / TaskPrioritizer / TaskScheduler
  • TODO Dust -> points / bloom_points, then ask around

justheuristic added a commit that referenced this pull request Aug 29, 2022
- Maximum length is now provided in `.inference_session(max_length=100)`
   - previously, we would always assume max length = 2048
- added a generic way to forward **kwargs to inference session
  - for compatibility with #47 
  - Note to @borzunov : it does *not* pass them arbitrarily, but instead checks for kwarg names at the bottom level
- run_server can be started with a custom max_length for inference
- renamed --cache_size_bytes to --attention_cache_bytes (to avoid collision with --cache_dir)
- --attn_cache_bytes can now support humane file sizes (e.g. 300MB instead of 314572800)
- made some server-side errors more human-readable to user (e.g. when max length is exceeded)

Co-authored-by: Aleksandr Borzunov <borzunov.alexander@gmail.com>
Co-authored-by: Alexander Borzunov <hxrussia@gmail.com>
@justheuristic justheuristic marked this pull request as ready for review September 7, 2022 03:53
@GreenFatGuy
Copy link
Collaborator Author

GreenFatGuy commented Sep 7, 2022

TODO:

  • reimplement forward/backward for RemoteSequential in a way that one can pass arbitrary metadata with request
  • Implement spending policy on client side. The plan is to put it inside SequenceManager
  • Test client side

@justheuristic please correct me if I am wrong about anything

@justheuristic justheuristic merged commit 50535a8 into main Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants