Support macOS natively #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
force-pushed
the
macos-support
branch
from
918e483
to
364966e
Compare
borzunov
force-pushed
the
macos-support
branch
2 times, most recently
from
98ad98f
to
70b8418
Compare
borzunov
force-pushed
the
macos-support
branch
from
70b8418
to
e4fcad8
Compare
borzunov
force-pushed
the
macos-support
branch
from
4be68c1
to
22d1968
Compare
borzunov
commented
Aug 28, 2023
| @@ -31,27 +50,13 @@ def get_pools(self): | |||
| PrioritizedTaskPool(dummy_pool_func, name="B", max_batch_size=1), | |||
| ) | |||
|
|
|||
| # Simulate requests coming from ConnectionHandlers | |||
| proc = mp.context.ForkProcess(target=_submit_tasks, args=(pools, results_valid)) | |||
| proc.start() | |||
There was a problem hiding this comment.
Moving that before Runtime.start() since (a) that's how real server works and (b) so we don't fork after creating active threads (this provably improves test stability)
justheuristic
approved these changes
Aug 28, 2023
| - { model: 'bigscience/bloom-560m', os: 'ubuntu', python-version: '3.8' } | ||
| - { model: 'bigscience/bloom-560m', os: 'ubuntu', python-version: '3.11' } | ||
| - { model: 'Maykeye/TinyLLama-v0', os: 'ubuntu', python-version: '3.8' } | ||
| - { model: 'Maykeye/TinyLLama-v0', os: 'ubuntu', python-version: '3.11' } |
There was a problem hiding this comment.
- would be nice to add adapters for llama tests since they are the new main
- if no time, please create an issue
borzunov
force-pushed
the
macos-support
branch
2 times, most recently
from
ce2a348
to
f47e922
Compare
borzunov
force-pushed
the
macos-support
branch
from
f47e922
to
b79c357
Compare
borzunov
force-pushed
the
macos-support
branch
from
aaa9a17
to
44a8b58
Compare
borzunov
force-pushed
the
macos-support
branch
2 times, most recently
from
568a1c4
to
8889cab
Compare
borzunov
force-pushed
the
macos-support
branch
from
8889cab
to
7bdf6e8
Compare
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes both clients and servers work on macOS. Specifically, it:
p2pdbinary (both x86-64 and ARM64 are supported)