Make ServerState announcements work better #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
ServerState.JOINING
was announced only once. This announcement quickly expires in case of the full-size BLOOM, since loading blocks takes several minutes. This PR fixes it, soServerState.JOINING
is announced periodically in a thread until blocks are loaded.This PR also makes the
Server
class a non-thread, so it runs in the main thread and can catchKeyboardInterrupt
. This is important, since if we are downloading blocks right now, we need to stop it and send theServerState.OFFLINE
message. Note thatModuleContainer
is still a thread.(minor) For the sake of readability, I moved the
ModuleContainer.create()
definition, so it is now defined beforeServer.__init__()
(this is because.create()
is invoked first).