newspop template #186
Merged
newspop template #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@stephenbach: This PR is just for newspop. |
stephenbach
requested changes
Jun 11, 2021
There was a problem hiding this comment.
Thank you!
Just a couple of suggestions:
- For evaluation purposes and consistency with other datasets, can you take out the prefixes in the output like "Topic:". You could put them in the input, particularly in cases like
template_6where there's nothing in the input telling the model what to do. - Can you capitalize proper nouns like Microsoft, Obama, and Palestine?
stephenbach
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.