Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color and layout #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bruceanwyl
Copy link

@bruceanwyl bruceanwyl commented Oct 5, 2019

This branch contains fixes for the following issues...
Barcode not centered #1
foregroundColor doesn't work #3
Barcode is rendered outside the canvas #13
Code93 barcode has extra bars on the end #14

This is a breaking change, due to the backgroundColor and foregroundColor support added, so the version is updated to 2.0.0 in pubspec.yaml

I also

  • Changed the demo layout a little to make it more obvious what is being displayed.
  • Removed "new" before all constructors as it is no longer required in Dart.
  • Apologise for changes that are only for layout caused by auto format in Visual Studio Code.
  • Renamed barcode_img.dart to barcode_image.dart to match your other conventions

Barcode not centered bigship#1
foregroundColor doesn't work bigship#3
Barcode is rendered outside the canvas bigship#13
Code93 barcode has extra bars on the end bigship#14
Copy link
Contributor

@v0l v0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly linting changes

@HugoHeneault
Copy link

This should be merged! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants