Add ITF Support #19
Merged
Add ITF Support #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure code to support parameter class files Remove new keyword usage from some areas fix formatting fix padding issues with canvas size
This was referenced Oct 10, 2019
Closed
Closed
Only implmented for ITF
|
@bigship any thoughts/comments? |
|
I have midterm exams this two weeks. Your solution seems good to me , I
will merge it to master
Thanks !
Kieran <notifications@github.com>于2019年10月24日 周四03:26写道：
… @bigship <https://github.com/bigship> any thoughts/comments?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AAJAHVPXNQU6RXENHMFW5ADQQFE3XA5CNFSM4I7O5MSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEAFGI#issuecomment-545784473>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJAHVMGMKTX3UQTEH4NZRLQQFE3XANCNFSM4I7O5MSA>
.
|
|
Sure, and adjust the README accordingly.
Kieran <notifications@github.com>于2019年10月24日 周四15:25写道：
… I think i can add a backward compatible api too, dont commit this yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AAJAHVKYC636EBPYMI4SGJLQQHZDFA5CNFSM4I7O5MSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECGE73I#issuecomment-546066413>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJAHVOUABPS5BPBMVHSHBTQQHZDFANCNFSM4I7O5MSA>
.
|
|
I went with changing the version to 1.1.0 instead of 2.0.0 since its backward compatible, later this can be removed completely.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes formatting and padding fixes.
I've replaced the usage of
BarCodeTypewith an abstract classBarCodeParamswhich will allow custom params for each barcode type, which i believe is a change worth implementing for future expand-ability.