Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on events dispatched by SSE extension to SSE documentation #25

Merged
merged 3 commits into from
May 29, 2024

Conversation

vlence
Copy link
Contributor

@vlence vlence commented May 22, 2024

Describe the events dispatched by the SSE event in the style of how the HTMX events are documented.

Describe the events dispatched by the SSE event in the style of how the HTMX events are documented.
Copy link

netlify bot commented May 22, 2024

Deploy Preview for htmx-extensions canceled.

Name Link
🔨 Latest commit 750444b
🔍 Latest deploy log https://app.netlify.com/sites/htmx-extensions/deploys/6656aa57f8282f0008878153

src/sse/README.md Outdated Show resolved Hide resolved
src/sse/README.md Show resolved Hide resolved
src/sse/README.md Outdated Show resolved Hide resolved
src/sse/README.md Outdated Show resolved Hide resolved
src/sse/README.md Outdated Show resolved Hide resolved
I had copied the section from another event and forgot to update it.
Added EventSource links to the `htmx:sseError` section that I missed in the previous commit.

Also fix the sections on `htmx:sseBeforeMessage` and `htmx:sseMessage`.

Should've read the source code more closely. SMH.
Copy link
Contributor Author

@vlence vlence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made fixes as recommended by @Telroshan

@Telroshan Telroshan added the documentation Improvements or additions to documentation label May 29, 2024
@Telroshan Telroshan merged commit 26b1637 into bigskysoftware:main May 29, 2024
5 checks passed
@Telroshan
Copy link
Collaborator

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants