fix #33 - include empty input values in request

bigskysoftware · May 23, 2020 · 468c405 · 468c405
1 parent f86ee98
commit 468c405
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8,335 deletions.
diff --git a/src/htmx.js b/src/htmx.js
@@ -969,7 +969,7 @@ var htmx = htmx || (function () {
             if (shouldInclude(elt)) {
                 var name = getRawAttribute(elt,"name");
                 var value = elt.value;
-                if (name && value) {
+                if (name != null && value != null) {
                     var current = values[name];
                     if(current) {
                         if (Array.isArray(current)) {

diff --git a/test/core/regressions.js b/test/core/regressions.js
@@ -35,4 +35,18 @@ describe("Core htmx Regression Tests", function(){
         htmx.find("#message2").innerHTML.should.equal("I came from a message2 oob swap I should be third  but I am in the wrong spot")
     });
 
+    it ('Handles https://github.com/bigskysoftware/htmx/issues/33 "empty values" properly', function() {
+        this.server.respondWith("POST", "/htmx.php", function (xhr) {
+            xhr.respond(200, {}, xhr.requestBody);
+        });
+
+        var form = make('<form hx-trigger="click" hx-post="/htmx.php">\n' +
+            '<input type="text" name="variable" value="">\n' +
+            '<button type="submit">Submit</button>\n' +
+            '</form>')
+        form.click();
+        this.server.respond();
+        form.innerHTML.should.equal("variable=")
+    });
+
 })
diff --git a/test/index.html b/test/index.html
@@ -96,7 +96,6 @@ <h2>Mocha Test Suite</h2>
 
 <script src="lib/handlebars-v4.7.6.js"></script>
 <script src="lib/mustache.js"></script>
-<script src="lib/nunjucks.js"></script>
 <script src="../src/ext/client-side-templates.js"></script>
 <script src="ext/client-side-templates.js"></script>