Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Scroll example with table of agents #1

Merged
merged 1 commit into from
May 11, 2020

Conversation

inouire
Copy link
Contributor

@inouire inouire commented May 11, 2020

Here is where I am so far, but the revealed trigger does not seem to work properly, it just works for the first element. When I fallback on a classical click trigger, it works

Another thing, I found an inconsistency on afterend (in the code) and afterEnd (in the doc)
Which one is the good one?

Thanks

@inouire inouire marked this pull request as draft May 11, 2020 15:40
@inouire inouire changed the title WIP Infinite Scroll example with table of agents Infinite Scroll example with table of agents May 11, 2020
@1cg
Copy link
Contributor

1cg commented May 11, 2020

Docs are wrong, should be afterend :/:

https://developer.mozilla.org/en-US/docs/Web/API/Element/insertAdjacentHTML

Are you comfortable debugging the javascript? I can look at it it not.

@inouire
Copy link
Contributor Author

inouire commented May 11, 2020

Not really confortable to debug it :/ Thanks

@1cg 1cg marked this pull request as ready for review May 11, 2020 18:10
@1cg 1cg merged commit 2d2100b into bigskysoftware:master May 11, 2020
1cg pushed a commit that referenced this pull request Jun 11, 2020
Just getting back up to date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants