Clear cache when historyCacheSize is set to 0 #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, if you're still interested in merging those changes, could you please retarget your PR to the |
aomader
force-pushed
the
clear-history-cache
branch
from
ab39b8d
to
70523ad
Compare
|
@Telroshan Here you go. |
Telroshan
added
the
ready for review
alexpetros
changed the title
1cg
requested changes
Oct 7, 2023
src/htmx.js
Outdated
| @@ -2193,6 +2193,7 @@ return (function () { | |||
| historyCache.shift(); // shrink the cache and retry | |||
| } | |||
| } | |||
| if (historyCache.length === 0) localStorage.removeItem("htmx-history-cache"); | |||
There was a problem hiding this comment.
can you add a comment here?
Also maybe this should be up near the top and avoid all the logic in this method?
There was a problem hiding this comment.
@aomader can you check in on this? Would like to merge this change
There was a problem hiding this comment.
@1cg I added a comment and moved it to the top to exit early. Note however that this changes the current behavior w.r.t. the htmx:historyItemCreated that was triggered up until now. However, I'd argue that the new behavior is more correct.
aomader
force-pushed
the
clear-history-cache
branch
from
70523ad
to
6c20464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1221