Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in www/ #1579

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Fix typos in www/ #1579

merged 2 commits into from
Jul 17, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jul 15, 2023 •
edited
Loading

Found some misspellings with typos.
Excluded paths:

  • dist/
  • test/lib/
  • test/realtime/static/data.json
  • www/static/test/

Please regenerate dist files after this PR. I am totally lost in this repo!

@alexpetros
Copy link
Collaborator

alexpetros commented Jul 17, 2023 •
edited
Loading

Hi @szepeviktor, thanks for contributing! Would you please remove the changes that are not in the www folder? Per the contribution guidelines, non-docs changes are pulled against the dev branch, not the master branch.

@szepeviktor
Copy link
Contributor Author

All right ...

@szepeviktor
Copy link
Contributor Author

Done 🍏

@szepeviktor szepeviktor changed the title Fix typos Fix typos in www/ Jul 17, 2023
alexpetros
alexpetros requested changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for removing the non-docs changes. Only one bit of feedback, and with that change it otherwise looks great.

www/content/docs.md Outdated
Comment on lines 1343 to 1345
<a class="tabs active" hx-get="/tabl1" >Tab 1</a>
<a class="tabs" hx-get="/tabl2">Tab 2</a>
<a class="tabs" hx-get="/tabl3">Tab 3</a>
<a class="tabs active" hx-get="/tab1" >Tab 1</a>
<a class="tabs" hx-get="/tab2">Tab 2</a>
<a class="tabs" hx-get="/tab3">Tab 3</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not typos (as far as I can tell)

Copy link
Contributor Author

@szepeviktor szepeviktor Jul 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know.
typos - the tool I used found it.
Should they be table1 or tab-left1 or tab-leaf1?

Copy link
Contributor Author

@szepeviktor szepeviktor Jul 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the original example in intercooler.js https://intercoolerjs.org/attributes/ic-switch-class.html

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there's a reason the API route needs to be tab instead of tabl (which are both short versions of "table"), this seems like a change for the purpose of making a change, which we don't need.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, reverting.
Note: "tabl" is not a word.

@szepeviktor szepeviktor mentioned this pull request Jul 17, 2023
Merged
alexpetros
alexpetros approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making those changes!

@alexpetros alexpetros merged commit 0a471dc into bigskysoftware:master Jul 17, 2023
6 checks passed
@szepeviktor szepeviktor deleted the fix-typos branch July 17, 2023 14:41
@szepeviktor
Copy link
Contributor Author

You're welcome.

My heart aches 🙃 tabl, tabl, tabl ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpetros alexpetros alexpetros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szepeviktor @alexpetros