Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for HX Retarget and fix typo #1600

Merged
merged 1 commit into from Jul 18, 2023
Merged

Add tests for HX Retarget and fix typo #1600

merged 1 commit into from Jul 18, 2023

Conversation

matiboy
Copy link
Contributor

@matiboy matiboy commented Jul 18, 2023 •
edited

@matiboy matiboy changed the base branch from master to dev July 18, 2023 04:06
@alexpetros
Copy link
Collaborator

This rocks so much. I also pulled the PR and reverted the source change to see if the new tests failed and one of them did! Thanks a ton.

@alexpetros alexpetros added bug Something isn't working ready for review Issues that are ready to be considered for merging labels Jul 18, 2023
@1cg 1cg self-requested a review July 18, 2023 16:10
@1cg 1cg merged commit f20791c into bigskysoftware:dev Jul 18, 2023
6 checks passed
@szepeviktor
Copy link
Contributor

Thank you @matiboy!

@matiboy matiboy deleted the issue-1598 branch July 18, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1cg 1cg Awaiting requested review from 1cg

Assignees
No one assigned
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response Target extension does not correctly set "shouldSwap"
4 participants
@matiboy @alexpetros @szepeviktor @1cg