[websocket] pass hx-target id in the HEADERS #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Renerick if you rebase against |
Previously, ws.js used `ws-connect` element as target when collecting request headers. Now it correctly takes `hx-target` attribute into account
Renerick
force-pushed
the
websocket-target-header
branch
from
65537a9
to
3f089d2
Compare
|
@alexpetros I think it's somehow worse now lol |
Renerick
added
enhancement
|
@Renerick re-ran it, good to go. |
Renerick
added
the
ready for review
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ws.js used
ws-connectelement as target when collecting request headers. Now it correctly takeshx-targetattribute into account